32 lines
1.4 KiB
Diff
32 lines
1.4 KiB
Diff
|
From 3d7b0ca5300bd01b176f2b4c10e173db802560d8 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Colin Ian King <colin.king@canonical.com>
|
||
|
|
Date: Tue, 21 Jul 2020 16:06:13 +0100
|
||
|
|
Subject: phy: qualcomm: fix setting of tx_deamp_3_5db when device property
|
||
|
|
read fails
|
||
|
|
|
||
|
|
Currently when reading of the device property for "qcom,tx-deamp_3_5db"
|
||
|
|
fails the default is being assigned incorrectly to phy_dwc3->rx_eq. This
|
||
|
|
looks like a copy-n-paste error and in fact should be assigning the
|
||
|
|
default instead to phy_dwc3->tx_deamp_3_5db
|
||
|
|
|
||
|
|
Addresses-Coverity: ("Copy-paste error")
|
||
|
|
Fixes: ef19b117b834 ("phy: qualcomm: add qcom ipq806x dwc usb phy driver")
|
||
|
|
Signed-off-by: Colin Ian King <colin.king@canonical.com>
|
||
|
|
Link: https://lore.kernel.org/r/20200721150613.416876-1-colin.king@canonical.com
|
||
|
|
Signed-off-by: Vinod Koul <vkoul@kernel.org>
|
||
|
|
---
|
||
|
|
drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c | 2 +-
|
||
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||
|
|
|
||
|
|
--- a/drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c
|
||
|
|
+++ b/drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c
|
||
|
|
@@ -531,7 +531,7 @@ static int qcom_ipq806x_usb_phy_probe(st
|
||
|
|
|
||
|
|
if (device_property_read_u32(&pdev->dev, "qcom,tx-deamp_3_5db",
|
||
|
|
&phy_dwc3->tx_deamp_3_5db))
|
||
|
|
- phy_dwc3->rx_eq = SSPHY_TX_DEEMPH_3_5DB;
|
||
|
|
+ phy_dwc3->tx_deamp_3_5db = SSPHY_TX_DEEMPH_3_5DB;
|
||
|
|
|
||
|
|
if (device_property_read_u32(&pdev->dev, "qcom,mpll", &phy_dwc3->mpll))
|
||
|
|
phy_dwc3->mpll = SSPHY_MPLL_VALUE;
|