From dc46ad16ae71528f6c1789d14c2502e0f931127f Mon Sep 17 00:00:00 2001
From: Ozzieisaacs <ozzie.fernandez.isaacs@googlemail.com>
Date: Sun, 26 Apr 2020 11:35:47 +0200
Subject: [PATCH] Bugfix view shelfs on book detail page

---
 cps/templates/detail.html | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/cps/templates/detail.html b/cps/templates/detail.html
index 03628559..c336ac66 100644
--- a/cps/templates/detail.html
+++ b/cps/templates/detail.html
@@ -226,7 +226,7 @@
           </button>
           <ul id="add-to-shelves" class="dropdown-menu" aria-labelledby="add-to-shelf">
             {% for shelf in g.shelves_access %}
-              {% if not shelf.id in books_shelfs %}
+              {% if not shelf.id in books_shelfs and ( not shelf.is_public or g.user.role_edit_shelfs() ) %}
                 <li>
                   <a href="{{ url_for('shelf.add_to_shelf', book_id=entry.id, shelf_id=shelf.id) }}"
                      data-remove-href="{{ url_for('shelf.remove_from_shelf', book_id=entry.id, shelf_id=shelf.id) }}"
@@ -247,7 +247,9 @@
                    data-add-href="{{ url_for('shelf.add_to_shelf', book_id=entry.id, shelf_id=shelf.id) }}"
                    class="btn btn-sm btn-default" role="button" data-shelf-action="remove"
                 >
-                  <span class="glyphicon glyphicon-remove"></span> {{shelf.name}}
+                  <span {% if not shelf.is_public or g.user.role_edit_shelfs() %}
+                        class="glyphicon glyphicon-remove"
+                        {% endif %}></span> {{shelf.name}}
                 </a>
               {% endif %}
             {%endfor%}