02629d8f87
Targets were build tested and patches are refreshed. Signed-off-by: Luka Perkov <luka@openwrt.org> SVN-Revision: 42463
91 lines
2.4 KiB
Diff
91 lines
2.4 KiB
Diff
From 286113578287b9c7619b4104864cffb91820f49d Mon Sep 17 00:00:00 2001
|
|
From: Stephen Boyd <sboyd@codeaurora.org>
|
|
Date: Thu, 6 Mar 2014 22:44:45 -0800
|
|
Subject: [PATCH 031/182] pinctrl: msm: Remove impossible WARN_ON()s
|
|
|
|
All these functions are limited in what they can pass as the gpio
|
|
or irq number to whatever is setup during probe. Remove the
|
|
checks.
|
|
|
|
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
|
|
Acked-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
|
|
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
|
|
---
|
|
drivers/pinctrl/pinctrl-msm.c | 16 ----------------
|
|
1 file changed, 16 deletions(-)
|
|
|
|
--- a/drivers/pinctrl/pinctrl-msm.c
|
|
+++ b/drivers/pinctrl/pinctrl-msm.c
|
|
@@ -401,8 +401,6 @@ static int msm_gpio_direction_input(stru
|
|
u32 val;
|
|
|
|
g = &pctrl->soc->groups[offset];
|
|
- if (WARN_ON(g->io_reg < 0))
|
|
- return -EINVAL;
|
|
|
|
spin_lock_irqsave(&pctrl->lock, flags);
|
|
|
|
@@ -423,8 +421,6 @@ static int msm_gpio_direction_output(str
|
|
u32 val;
|
|
|
|
g = &pctrl->soc->groups[offset];
|
|
- if (WARN_ON(g->io_reg < 0))
|
|
- return -EINVAL;
|
|
|
|
spin_lock_irqsave(&pctrl->lock, flags);
|
|
|
|
@@ -451,8 +447,6 @@ static int msm_gpio_get(struct gpio_chip
|
|
u32 val;
|
|
|
|
g = &pctrl->soc->groups[offset];
|
|
- if (WARN_ON(g->io_reg < 0))
|
|
- return -EINVAL;
|
|
|
|
val = readl(pctrl->regs + g->io_reg);
|
|
return !!(val & BIT(g->in_bit));
|
|
@@ -466,8 +460,6 @@ static void msm_gpio_set(struct gpio_chi
|
|
u32 val;
|
|
|
|
g = &pctrl->soc->groups[offset];
|
|
- if (WARN_ON(g->io_reg < 0))
|
|
- return;
|
|
|
|
spin_lock_irqsave(&pctrl->lock, flags);
|
|
|
|
@@ -616,8 +608,6 @@ static void msm_gpio_irq_mask(struct irq
|
|
|
|
pctrl = irq_data_get_irq_chip_data(d);
|
|
g = &pctrl->soc->groups[d->hwirq];
|
|
- if (WARN_ON(g->intr_cfg_reg < 0))
|
|
- return;
|
|
|
|
spin_lock_irqsave(&pctrl->lock, flags);
|
|
|
|
@@ -639,8 +629,6 @@ static void msm_gpio_irq_unmask(struct i
|
|
|
|
pctrl = irq_data_get_irq_chip_data(d);
|
|
g = &pctrl->soc->groups[d->hwirq];
|
|
- if (WARN_ON(g->intr_status_reg < 0))
|
|
- return;
|
|
|
|
spin_lock_irqsave(&pctrl->lock, flags);
|
|
|
|
@@ -666,8 +654,6 @@ static void msm_gpio_irq_ack(struct irq_
|
|
|
|
pctrl = irq_data_get_irq_chip_data(d);
|
|
g = &pctrl->soc->groups[d->hwirq];
|
|
- if (WARN_ON(g->intr_status_reg < 0))
|
|
- return;
|
|
|
|
spin_lock_irqsave(&pctrl->lock, flags);
|
|
|
|
@@ -692,8 +678,6 @@ static int msm_gpio_irq_set_type(struct
|
|
|
|
pctrl = irq_data_get_irq_chip_data(d);
|
|
g = &pctrl->soc->groups[d->hwirq];
|
|
- if (WARN_ON(g->intr_cfg_reg < 0))
|
|
- return -EINVAL;
|
|
|
|
spin_lock_irqsave(&pctrl->lock, flags);
|
|
|