f07e572f64
bcm2708: boot tested on RPi B+ v1.2 bcm2709: boot tested on RPi 3B v1.2 and RPi 4B v1.1 4G bcm2710: boot tested on RPi 3B v1.2 bcm2711: boot tested on RPi 4B v1.1 4G Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
38 lines
1.2 KiB
Diff
38 lines
1.2 KiB
Diff
From d2155366275ce70438d12169a59959e90b637f9c Mon Sep 17 00:00:00 2001
|
|
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
|
|
Date: Fri, 12 Jun 2020 15:53:54 +0200
|
|
Subject: [PATCH] media: i2c: imx290: Move the settle time delay out
|
|
of loop
|
|
|
|
Commit 6544af9b04b4484867c234ba0be1b5008e4a14ee upstream.
|
|
|
|
The 10ms settle time is needed only at the end of all consecutive
|
|
register writes. So move the delay to outside of the for loop of
|
|
imx290_set_register_array().
|
|
|
|
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
|
|
Signed-off-by: Andrey Konovalov <andrey.konovalov@linaro.org>
|
|
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
|
|
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
|
|
---
|
|
drivers/media/i2c/imx290.c | 6 +++---
|
|
1 file changed, 3 insertions(+), 3 deletions(-)
|
|
|
|
--- a/drivers/media/i2c/imx290.c
|
|
+++ b/drivers/media/i2c/imx290.c
|
|
@@ -404,11 +404,11 @@ static int imx290_set_register_array(str
|
|
ret = imx290_write_reg(imx290, settings->reg, settings->val);
|
|
if (ret < 0)
|
|
return ret;
|
|
-
|
|
- /* Settle time is 10ms for all registers */
|
|
- msleep(10);
|
|
}
|
|
|
|
+ /* Provide 10ms settle time */
|
|
+ msleep(10);
|
|
+
|
|
return 0;
|
|
}
|
|
|