f07e572f64
bcm2708: boot tested on RPi B+ v1.2 bcm2709: boot tested on RPi 3B v1.2 and RPi 4B v1.1 4G bcm2710: boot tested on RPi 3B v1.2 bcm2711: boot tested on RPi 4B v1.1 4G Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
35 lines
1.2 KiB
Diff
35 lines
1.2 KiB
Diff
From 31fe609e3f5f9d4e52f0f88f8ebfd20fb606c672 Mon Sep 17 00:00:00 2001
|
|
From: Maxime Ripard <maxime@cerno.tech>
|
|
Date: Fri, 7 Feb 2020 15:47:13 +0100
|
|
Subject: [PATCH] clk: bcm: rpi: Make sure the clkdev lookup is removed
|
|
|
|
The clkdev lookup created for the cpufreq device is never removed if
|
|
there's an issue later in probe or at module removal time.
|
|
|
|
Let's convert to the managed variant of the clk_hw_register_clkdev function
|
|
to make sure it happens.
|
|
|
|
Cc: Michael Turquette <mturquette@baylibre.com>
|
|
Cc: linux-clk@vger.kernel.org
|
|
Acked-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
|
|
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
|
|
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
|
|
---
|
|
drivers/clk/bcm/clk-raspberrypi.c | 5 +++--
|
|
1 file changed, 3 insertions(+), 2 deletions(-)
|
|
|
|
--- a/drivers/clk/bcm/clk-raspberrypi.c
|
|
+++ b/drivers/clk/bcm/clk-raspberrypi.c
|
|
@@ -245,8 +245,9 @@ static int raspberrypi_register_pllb_arm
|
|
return ret;
|
|
}
|
|
|
|
- ret = clk_hw_register_clkdev(&raspberrypi_clk_pllb_arm.hw,
|
|
- NULL, "cpu0");
|
|
+ ret = devm_clk_hw_register_clkdev(rpi->dev,
|
|
+ &raspberrypi_clk_pllb_arm.hw,
|
|
+ NULL, "cpu0");
|
|
if (ret) {
|
|
dev_err(rpi->dev, "Failed to initialize clkdev\n");
|
|
return ret;
|