mvebu: add some more flash driver fixes
Disable marvell,nand-keep-config property on WRT1900AC to allow the flash driver to properly probe the chip Signed-off-by: Felix Fietkau <nbd@nbd.name>
This commit is contained in:
parent
008579f2ff
commit
a5a3b59bf5
@ -0,0 +1,42 @@
|
|||||||
|
From: =?UTF-8?q?Ezequiel=20Garc=C3=ADa?= <ezequiel@vanguardiasur.com.ar>
|
||||||
|
Date: Wed, 4 Nov 2015 13:13:41 -0300
|
||||||
|
Subject: [PATCH] mtd: pxa3xx_nand: Increase the initial chunk size
|
||||||
|
|
||||||
|
The chunk size represents the size of the data chunks, which
|
||||||
|
is used by the controllers that allow to split transfered data.
|
||||||
|
|
||||||
|
However, the initial chunk size is used in a non-splitted way,
|
||||||
|
during device identification. Therefore, it must be large enough
|
||||||
|
for all the NAND commands issued during device identification.
|
||||||
|
This includes NAND_CMD_PARAM which was recently changed to
|
||||||
|
transfer up to 2048 bytes (for the redundant parameter pages).
|
||||||
|
|
||||||
|
Thus, the initial chunk size should be 2048 as well.
|
||||||
|
|
||||||
|
On Armada 370/XP platforms (NFCv2) booted without the keep-config
|
||||||
|
devicetree property, this commit fixes a timeout on the NAND_CMD_PARAM
|
||||||
|
command:
|
||||||
|
|
||||||
|
[..]
|
||||||
|
pxa3xx-nand f10d0000.nand: This platform can't do DMA on this device
|
||||||
|
pxa3xx-nand f10d0000.nand: Wait time out!!!
|
||||||
|
nand: device found, Manufacturer ID: 0x2c, Chip ID: 0x38
|
||||||
|
nand: Micron MT29F8G08ABABAWP
|
||||||
|
nand: 1024 MiB, SLC, erase size: 512 KiB, page size: 4096, OOB size: 224
|
||||||
|
|
||||||
|
Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
|
||||||
|
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
|
||||||
|
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
|
||||||
|
---
|
||||||
|
|
||||||
|
--- a/drivers/mtd/nand/pxa3xx_nand.c
|
||||||
|
+++ b/drivers/mtd/nand/pxa3xx_nand.c
|
||||||
|
@@ -1636,7 +1636,7 @@ static int pxa3xx_nand_scan(struct mtd_i
|
||||||
|
goto KEEP_CONFIG;
|
||||||
|
|
||||||
|
/* Set a default chunk size */
|
||||||
|
- info->chunk_size = 512;
|
||||||
|
+ info->chunk_size = PAGE_CHUNK_SIZE;
|
||||||
|
|
||||||
|
ret = pxa3xx_nand_config_flash(info);
|
||||||
|
if (ret)
|
@ -0,0 +1,104 @@
|
|||||||
|
From: =?UTF-8?q?Ezequiel=20Garc=C3=ADa?= <ezequiel@vanguardiasur.com.ar>
|
||||||
|
Date: Wed, 4 Nov 2015 13:13:42 -0300
|
||||||
|
Subject: [PATCH] mtd: pxa3xx_nand: Fix initial controller configuration
|
||||||
|
|
||||||
|
The Data Flash Control Register (NDCR) contains two types
|
||||||
|
of parameters: those that are needed for device identification,
|
||||||
|
and those that can only be set after device identification.
|
||||||
|
|
||||||
|
Therefore, the driver can't set them all at once and instead
|
||||||
|
needs to configure the first group before nand_scan_ident()
|
||||||
|
and the second group later.
|
||||||
|
|
||||||
|
Let's split pxa3xx_nand_config in two halves, and set the
|
||||||
|
parameters that depend on the device geometry once this is known.
|
||||||
|
|
||||||
|
Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
|
||||||
|
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
|
||||||
|
---
|
||||||
|
|
||||||
|
--- a/drivers/mtd/nand/pxa3xx_nand.c
|
||||||
|
+++ b/drivers/mtd/nand/pxa3xx_nand.c
|
||||||
|
@@ -1419,34 +1419,43 @@ static int pxa3xx_nand_waitfunc(struct m
|
||||||
|
return NAND_STATUS_READY;
|
||||||
|
}
|
||||||
|
|
||||||
|
-static int pxa3xx_nand_config_flash(struct pxa3xx_nand_info *info)
|
||||||
|
+static int pxa3xx_nand_config_ident(struct pxa3xx_nand_info *info)
|
||||||
|
{
|
||||||
|
struct platform_device *pdev = info->pdev;
|
||||||
|
struct pxa3xx_nand_platform_data *pdata = dev_get_platdata(&pdev->dev);
|
||||||
|
- struct pxa3xx_nand_host *host = info->host[info->cs];
|
||||||
|
- struct mtd_info *mtd = host->mtd;
|
||||||
|
- struct nand_chip *chip = mtd->priv;
|
||||||
|
|
||||||
|
- /* configure default flash values */
|
||||||
|
+ /* Configure default flash values */
|
||||||
|
+ info->chunk_size = PAGE_CHUNK_SIZE;
|
||||||
|
info->reg_ndcr = 0x0; /* enable all interrupts */
|
||||||
|
info->reg_ndcr |= (pdata->enable_arbiter) ? NDCR_ND_ARB_EN : 0;
|
||||||
|
info->reg_ndcr |= NDCR_RD_ID_CNT(READ_ID_BYTES);
|
||||||
|
- info->reg_ndcr |= NDCR_SPARE_EN; /* enable spare by default */
|
||||||
|
+ info->reg_ndcr |= NDCR_SPARE_EN;
|
||||||
|
+
|
||||||
|
+ return 0;
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+static void pxa3xx_nand_config_tail(struct pxa3xx_nand_info *info)
|
||||||
|
+{
|
||||||
|
+ struct pxa3xx_nand_host *host = info->host[info->cs];
|
||||||
|
+ struct mtd_info *mtd = host->mtd;
|
||||||
|
+ struct nand_chip *chip = mtd->priv;
|
||||||
|
+
|
||||||
|
info->reg_ndcr |= (host->col_addr_cycles == 2) ? NDCR_RA_START : 0;
|
||||||
|
info->reg_ndcr |= (chip->page_shift == 6) ? NDCR_PG_PER_BLK : 0;
|
||||||
|
info->reg_ndcr |= (mtd->writesize == 2048) ? NDCR_PAGE_SZ : 0;
|
||||||
|
-
|
||||||
|
- return 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
static int pxa3xx_nand_detect_config(struct pxa3xx_nand_info *info)
|
||||||
|
{
|
||||||
|
+ struct platform_device *pdev = info->pdev;
|
||||||
|
+ struct pxa3xx_nand_platform_data *pdata = dev_get_platdata(&pdev->dev);
|
||||||
|
uint32_t ndcr = nand_readl(info, NDCR);
|
||||||
|
|
||||||
|
/* Set an initial chunk size */
|
||||||
|
info->chunk_size = ndcr & NDCR_PAGE_SZ ? 2048 : 512;
|
||||||
|
info->reg_ndcr = ndcr &
|
||||||
|
~(NDCR_INT_MASK | NDCR_ND_ARB_EN | NFCV1_NDCR_ARB_CNTL);
|
||||||
|
+ info->reg_ndcr |= (pdata->enable_arbiter) ? NDCR_ND_ARB_EN : 0;
|
||||||
|
info->ndtr0cs0 = nand_readl(info, NDTR0CS0);
|
||||||
|
info->ndtr1cs0 = nand_readl(info, NDTR1CS0);
|
||||||
|
return 0;
|
||||||
|
@@ -1635,10 +1644,7 @@ static int pxa3xx_nand_scan(struct mtd_i
|
||||||
|
if (pdata->keep_config && !pxa3xx_nand_detect_config(info))
|
||||||
|
goto KEEP_CONFIG;
|
||||||
|
|
||||||
|
- /* Set a default chunk size */
|
||||||
|
- info->chunk_size = PAGE_CHUNK_SIZE;
|
||||||
|
-
|
||||||
|
- ret = pxa3xx_nand_config_flash(info);
|
||||||
|
+ ret = pxa3xx_nand_config_ident(info);
|
||||||
|
if (ret)
|
||||||
|
return ret;
|
||||||
|
|
||||||
|
@@ -1651,7 +1657,6 @@ static int pxa3xx_nand_scan(struct mtd_i
|
||||||
|
}
|
||||||
|
|
||||||
|
KEEP_CONFIG:
|
||||||
|
- info->reg_ndcr |= (pdata->enable_arbiter) ? NDCR_ND_ARB_EN : 0;
|
||||||
|
if (info->reg_ndcr & NDCR_DWIDTH_M)
|
||||||
|
chip->options |= NAND_BUSWIDTH_16;
|
||||||
|
|
||||||
|
@@ -1736,6 +1741,10 @@ KEEP_CONFIG:
|
||||||
|
host->row_addr_cycles = 3;
|
||||||
|
else
|
||||||
|
host->row_addr_cycles = 2;
|
||||||
|
+
|
||||||
|
+ if (!pdata->keep_config)
|
||||||
|
+ pxa3xx_nand_config_tail(info);
|
||||||
|
+
|
||||||
|
return nand_scan_tail(mtd);
|
||||||
|
}
|
||||||
|
|
@ -0,0 +1,10 @@
|
|||||||
|
--- a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
|
||||||
|
+++ b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
|
||||||
|
@@ -298,7 +298,6 @@
|
||||||
|
nand@d0000 {
|
||||||
|
status = "okay";
|
||||||
|
num-cs = <1>;
|
||||||
|
- marvell,nand-keep-config;
|
||||||
|
marvell,nand-enable-arbiter;
|
||||||
|
nand-on-flash-bbt;
|
||||||
|
nand-ecc-strength = <4>;
|
Loading…
Reference in New Issue
Block a user