EljakimHerrewijnen/Openwrt
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

uboot-oxnas: fix memory leak in tool mkox820crc

Browse Source 
In function `main` add calls to `free` for the variable `executable`.
This is needed because the variable `executable` is allocated but
never freed. This cause a memory leak.

Signed-off-by: Andrea Dalla Costa <andrea@dallacosta.me>
This commit is contained in:
Andrea Dalla Costa 2019-12-28 17:43:40 +01:00 committed by John Crispin
parent bbab32b2e3
commit 5adca1cf2a
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
package/boot/uboot-oxnas/src/tools/mkox820crc.c
View File

@ -84,6 +84,7 @@ int main(int argc, char **argv)
if (status != file_length) { if (status != file_length) {
printf("Failed to load image\n"); printf("Failed to load image\n");
free(executable);
return -ENOENT; return -ENOENT;
} }
@ -111,6 +112,7 @@ int main(int argc, char **argv)
status = lseek(in_file, 0, SEEK_SET); status = lseek(in_file, 0, SEEK_SET);
if (status != 0) { if (status != 0) {
printf("failed to rewind\n"); printf("failed to rewind\n");
free(executable);
return 1; return 1;
} }
len = write(in_file, &img_header, sizeof(img_header)); len = write(in_file, &img_header, sizeof(img_header));
@ -118,6 +120,7 @@ int main(int argc, char **argv)
len = write(in_file, executable, file_length); len = write(in_file, executable, file_length);
assert(len == file_length); assert(len == file_length);
close(in_file); close(in_file);
free(executable);
return 0; return 0;
} }