EljakimHerrewijnen/Openwrt
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

scripts/flashing/flash.sh: Add missing quotes

Browse Source 
These are in if statements (where they should be), and echo output that is
not piped to anything. These should be safe.

Found with shellcheck.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev 2020-01-05 18:27:06 -08:00 committed by Adrian Schmutzler
parent 9a1f4b2f83
commit 34a2780395
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
scripts/flashing/flash.sh
View File

@ -20,8 +20,8 @@
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
# #
if [ -z "$1" ] || [ ! -f $1 ] || [ -z $2 ]; then if [ -z "$1" ] || [ ! -f "$1" ] || [ -z "$2" ]; then
echo Usage: $0 firmware vendor echo Usage: "$0" firmware vendor
cat << EOF cat << EOF
IMPORTANT: IMPORTANT:
Notes for Linksys / Asus WL500gx router: Notes for Linksys / Asus WL500gx router:
@ -52,15 +52,15 @@ fi
if [ "$2" = "asus" ]; then if [ "$2" = "asus" ]; then
echo Confirming IP address setting... echo Confirming IP address setting...
echo -en "get ASUSSPACELINK\x01\x01\xa8\xc0 /dev/null\nquit\n" | tftp 192.168.1.1 echo -en "get ASUSSPACELINK\x01\x01\xa8\xc0 /dev/null\nquit\n" | tftp 192.168.1.1
echo Flashing 192.168.1.1 using $1... echo Flashing 192.168.1.1 using "$1"...
echo -en "binary\nput $1 ASUSSPACELINK\nquit\n" | tftp 192.168.1.1 echo -en "binary\nput $1 ASUSSPACELINK\nquit\n" | tftp 192.168.1.1
echo Please wait until leds stops flashing. echo Please wait until leds stops flashing.
elif [ "$2" = "linksys" ]; then elif [ "$2" = "linksys" ]; then
echo Flashing 192.168.1.1 using $1... echo Flashing 192.168.1.1 using "$1"...
echo -en "rexmt 1\ntrace\nbinary\nput $1\nquit\n" | tftp 192.168.1.1 echo -en "rexmt 1\ntrace\nbinary\nput $1\nquit\n" | tftp 192.168.1.1
echo Please wait until power led stops flashing. Do not poweroff! Then you can login via telnet 192.168.1.1. echo Please wait until power led stops flashing. Do not poweroff! Then you can login via telnet 192.168.1.1.
elif [ "$2" = "toshiba" ]; then elif [ "$2" = "toshiba" ]; then
echo Flashing 192.168.10.1 using $1... echo Flashing 192.168.10.1 using "$1"...
echo -en "rexmt 1\ntrace\nbinary\nput $1\nquit\n" | tftp 192.168.10.1 echo -en "rexmt 1\ntrace\nbinary\nput $1\nquit\n" | tftp 192.168.10.1
echo Unit will automatically reboot within 5 minutes. Do not power off. Then you can login via telnet 192.168.10.1. echo Unit will automatically reboot within 5 minutes. Do not power off. Then you can login via telnet 192.168.10.1.
fi fi