EljakimHerrewijnen/Openwrt
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

scripts/package-metadata.pl: remove broken detection of self-dependencies

Browse Source 
A self-dependency is not an error worth a warning; rather, it is very
common: whenever there are dependencies between different binary packages
originating from the same source package, such dependencies occur. Not
actually generating dependency rules is correct, but already handled a few
lines below.

A typo prevented this redundant rule from working, which is the reason the
warning was not actually printed.

Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
This commit is contained in:
Matthias Schiffer 2018-01-04 17:18:16 +01:00
parent da95c9aa17
commit 0b28cc56d4
No known key found for this signature in database
GPG Key ID: 16EF3F64CB201D9C
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
scripts/package-metadata.pl
View File

@ -535,11 +535,6 @@ sub gen_package_mk() {
$pkg->{makefile}, $pkg_dep->{src}, $deptype, $pkg_dep->{makefile}, $deptype; $pkg->{makefile}, $pkg_dep->{src}, $deptype, $pkg_dep->{makefile}, $deptype;
next; next;
} }
unless ($pkg->{src} ne $pkg_dep->{sec}.$suffix) {
warn sprintf "WARNING: Makefile '%s' has a build dependency on itself\n",
$pkg->{makefile};
next;
}
$idx = $pkg_dep->{subdir}.$pkg_dep->{src}; $idx = $pkg_dep->{subdir}.$pkg_dep->{src};
} elsif (defined($srcpackage{$dep})) { } elsif (defined($srcpackage{$dep})) {
$idx = $subdir{$dep}.$dep; $idx = $subdir{$dep}.$dep;