From 03cdbb20404410ef9cd0daea45fe3f17e1b745b5 Mon Sep 17 00:00:00 2001 From: Adrian Schmutzler Date: Mon, 17 Aug 2020 14:57:52 +0200 Subject: [PATCH] ramips: fix LED labels for Asus RT-AC65P The leds block was copied over from the RT-AC85P DTS to the common DTSI while keeping the device-specific model name in the label. This moves the LEDs back to the DTS files and adjusts the names to properly resemble the model name of the devices used at, just like it is handled on most other devices. Fixes: 7c5f712e4fec ("ramips: add support for Asus RT-AC65P") Signed-off-by: Adrian Schmutzler --- .../linux/ramips/dts/mt7621_asus_rt-ac65p.dts | 28 +++++++++++++++++++ .../linux/ramips/dts/mt7621_asus_rt-ac85p.dts | 28 +++++++++++++++++++ .../ramips/dts/mt7621_asus_rt-acx5p.dtsi | 27 ------------------ .../etc/uci-defaults/04_led_migration | 3 ++ 4 files changed, 59 insertions(+), 27 deletions(-) diff --git a/target/linux/ramips/dts/mt7621_asus_rt-ac65p.dts b/target/linux/ramips/dts/mt7621_asus_rt-ac65p.dts index 07a714a840..eaa82012c2 100644 --- a/target/linux/ramips/dts/mt7621_asus_rt-ac65p.dts +++ b/target/linux/ramips/dts/mt7621_asus_rt-ac65p.dts @@ -6,4 +6,32 @@ / { compatible = "asus,rt-ac65p", "mediatek,mt7621-soc"; model = "ASUS RT-AC65P"; + + aliases { + led-boot = &led_power; + led-failsafe = &led_power; + led-running = &led_power; + led-upgrade = &led_power; + }; + + leds { + compatible = "gpio-leds"; + + led_power: power { + label = "rt-ac65p:blue:power"; + gpios = <&gpio 4 GPIO_ACTIVE_LOW>; + }; + + wlan5g { + label = "rt-ac65p:blue:wlan5g"; + gpios = <&gpio 8 GPIO_ACTIVE_LOW>; + linux,default-trigger = "phy1radio"; + }; + + wlan2g { + label = "rt-ac65p:blue:wlan2g"; + gpios = <&gpio 10 GPIO_ACTIVE_LOW>; + linux,default-trigger = "phy0radio"; + }; + }; }; diff --git a/target/linux/ramips/dts/mt7621_asus_rt-ac85p.dts b/target/linux/ramips/dts/mt7621_asus_rt-ac85p.dts index add33bf2d1..28928b1d4c 100644 --- a/target/linux/ramips/dts/mt7621_asus_rt-ac85p.dts +++ b/target/linux/ramips/dts/mt7621_asus_rt-ac85p.dts @@ -6,4 +6,32 @@ / { compatible = "asus,rt-ac85p", "mediatek,mt7621-soc"; model = "ASUS RT-AC85P"; + + aliases { + led-boot = &led_power; + led-failsafe = &led_power; + led-running = &led_power; + led-upgrade = &led_power; + }; + + leds { + compatible = "gpio-leds"; + + led_power: power { + label = "rt-ac85p:blue:power"; + gpios = <&gpio 4 GPIO_ACTIVE_LOW>; + }; + + wlan5g { + label = "rt-ac85p:blue:wlan5g"; + gpios = <&gpio 8 GPIO_ACTIVE_LOW>; + linux,default-trigger = "phy1radio"; + }; + + wlan2g { + label = "rt-ac85p:blue:wlan2g"; + gpios = <&gpio 10 GPIO_ACTIVE_LOW>; + linux,default-trigger = "phy0radio"; + }; + }; }; diff --git a/target/linux/ramips/dts/mt7621_asus_rt-acx5p.dtsi b/target/linux/ramips/dts/mt7621_asus_rt-acx5p.dtsi index 0921a477e9..f31e74b051 100644 --- a/target/linux/ramips/dts/mt7621_asus_rt-acx5p.dtsi +++ b/target/linux/ramips/dts/mt7621_asus_rt-acx5p.dtsi @@ -6,13 +6,6 @@ #include / { - aliases { - led-boot = &led_power; - led-failsafe = &led_power; - led-running = &led_power; - led-upgrade = &led_power; - }; - keys { compatible = "gpio-keys"; @@ -28,26 +21,6 @@ linux,code = ; }; }; - - leds { - compatible = "gpio-leds"; - - led_power: power { - label = "rt-ac85p:blue:power"; - gpios = <&gpio 4 GPIO_ACTIVE_LOW>; - }; - wlan2g { - label = "rt-ac85p:blue:wlan2g"; - gpios = <&gpio 10 GPIO_ACTIVE_LOW>; - linux,default-trigger = "phy0radio"; - }; - - wlan5g { - label = "rt-ac85p:blue:wlan5g"; - gpios = <&gpio 8 GPIO_ACTIVE_LOW>; - linux,default-trigger = "phy1radio"; - }; - }; }; &i2c { diff --git a/target/linux/ramips/mt7621/base-files/etc/uci-defaults/04_led_migration b/target/linux/ramips/mt7621/base-files/etc/uci-defaults/04_led_migration index f9cf3eae0a..4b298654b6 100644 --- a/target/linux/ramips/mt7621/base-files/etc/uci-defaults/04_led_migration +++ b/target/linux/ramips/mt7621/base-files/etc/uci-defaults/04_led_migration @@ -5,6 +5,9 @@ board=$(board_name) boardonly="${board##*,}" case "$board" in +asus,rt-ac65p) + migrate_leds "^rt-ac85p:=rt-ac65p:" + ;; mikrotik,routerboard-750gr3) migrate_leds "^rb750gr3:=$boardonly:" ;;