2007-06-30 11:05:14 +00:00
diff -urN -x.svn hotplug2-0.9/AUTHORS hotplug2/AUTHORS
2007-06-25 09:46:37 +00:00
--- hotplug2-0.9/AUTHORS 2006-10-08 18:13:50.000000000 +0200
2007-06-30 11:05:14 +00:00
+++ hotplug2/AUTHORS 2007-06-30 12:59:20.459674000 +0200
2007-06-25 09:46:37 +00:00
@@ -1,7 +1,11 @@
Authors:
----------
iSteve <isteve@bofh.cz>
-Tomas Janousek <tomi@nomi.cz>
+
+ Contributions:
+----------------
2007-06-30 11:05:14 +00:00
+nbd (rules override patch, various fixes, suggestions, testing etc.)
2007-06-25 09:46:37 +00:00
+Tomas Janousek <tomi@nomi.cz> (Makefiles, SVN hosting)
Thanks to:
------------
@@ -10,5 +14,9 @@
Randy Dunlap (help with isapnpmap)
Igor2 (provided testing machines)
yanek (provided testing machines)
+Zdenek Styblik (provided testing OpenWRT device)
+OpenWRT team (for trusting this project)
+mtu (debugging, testing, ideas)
+mnemoc (trivial sanity changes on makefiles, linux24 compat patches)
-...anyone taking more than a short peek at the software.
\ No newline at end of file
+...anyone taking more than a short peek at the software.
2007-06-30 11:05:14 +00:00
diff -urN -x.svn hotplug2-0.9/Changelog hotplug2/Changelog
2007-06-25 09:46:37 +00:00
--- hotplug2-0.9/Changelog 2006-10-08 15:32:31.000000000 +0200
2007-06-30 11:05:14 +00:00
+++ hotplug2/Changelog 2007-06-28 14:51:00.009934640 +0200
2007-06-25 09:46:37 +00:00
@@ -1,3 +1,10 @@
+0.9 - 1.0:
+* Add --set-rules-file.
+* Allow any ACTION.
+* Add 'printdebug' rule.
+* Fix chmod, chown, chgrp.
+* Use octal for chmod and makedev.
+
0.8 - 0.9:
* Use signals to handle children.
* Separate info and debugging output.
@@ -44,4 +51,4 @@
* Add more actions.
* Significant cleanup of rules handling.
* Better error reporting.
-
\ No newline at end of file
+
2007-06-30 11:05:14 +00:00
diff -urN -x.svn hotplug2-0.9/common.mak hotplug2/common.mak
--- hotplug2-0.9/common.mak 2006-09-26 01:03:08.000000000 +0200
+++ hotplug2/common.mak 2007-06-28 14:54:56.013056712 +0200
@@ -10,7 +10,7 @@
.PHONY: all clean dep install install-recursive clean-recursive \
dep-recursive all-recursive
-MAKEDEP=-gcc $(CFLAGS) -MM $(wildcard *.c *.cc) > .depend
+MAKEDEP=-$(CC) $(CFLAGS) -MM $(wildcard *.c *.cc) > .depend
dep: dep-recursive
$(MAKEDEP)
.depend:
diff -urN -x.svn hotplug2-0.9/docs/hotplug2.8 hotplug2/docs/hotplug2.8
2007-06-25 09:46:37 +00:00
--- hotplug2-0.9/docs/hotplug2.8 2006-09-26 09:23:36.000000000 +0200
2007-06-30 11:05:14 +00:00
+++ hotplug2/docs/hotplug2.8 2007-06-28 14:50:59.874955160 +0200
@@ -22,6 +22,8 @@
.TP
\fB\-\-dumb\fR, \fB\-\-no\-dumb\fR
Run or do not run hotplug2 in dumb mode. Dumb mode means that rules are being ignored, the only action taken is mload modules to all devices whose uevent exports MODALIAS. Only available if compiled with HAVE_RULES.
+\fB\-\-override\fR, \fB\-\-no\-override\fR
+Allows hotplug2 behavior overriding for different rules, using various flags. See hotplug2 rules documentation for details. The default is not to allow overriding, the flags are therefore ignored.
.TP
\fB\-\-max\-children <value>\fR
Set the value of maximum children hotplug2 may have running simultaneously. Default is 20.
@@ -31,6 +33,8 @@
2007-06-25 09:46:37 +00:00
.TP
\fB\-\-set\-modprobe\-cmd <cmd>\fR
Sets the application used to perform modprobe. It only gets used in dumb mode. Default is to autodetect: if '/bin/modprobe' is from module\-init\-tools, use '/sbin/modprobe', otherwise use '/sbin/hotplug2\-modwrap'.
+\fB\-\-set\-rules\-file <file>\fR
+Sets the path to the file containing hotplug2 rules.
.SH "SIGNALS"
.TP
\fBSIGUSR1\fR
2007-06-30 11:05:14 +00:00
diff -urN -x.svn hotplug2-0.9/docs/hotplug2.rules.doc hotplug2/docs/hotplug2.rules.doc
2007-06-25 09:46:37 +00:00
--- hotplug2-0.9/docs/hotplug2.rules.doc 2006-09-26 10:19:46.000000000 +0200
2007-06-30 11:05:14 +00:00
+++ hotplug2/docs/hotplug2.rules.doc 2007-06-28 14:50:59.872955464 +0200
2007-06-25 09:46:37 +00:00
@@ -11,12 +11,12 @@
[... [...]]
}
-Comments are allowed, they are prefixed with '#', treating the whole rest of the
-line as comment. Please note that comments in place of action parameters are not
-supported.
+Comments are allowed, they are prefixed with '#', treating the whole rest of
+the line as comment. Please note that comments in place of action parameters
+are not supported.
-The <key> is one of the environmental variables that have been obtained by the
-uevent netlink.
+The <key> is one of the environmental variables that have been obtained by
+the uevent netlink.
COMMON KEYS
-----------
@@ -66,9 +66,9 @@
-------
* run <...>
- Execute an application using system();, takes one parameter. Note that
- the application has set all environmental variables read by uevent
- netlink.
+ Execute an application using system();, takes one parameter. Note
+ that the application has set all environmental variables read by
+ uevent netlink.
* break
Break the processing of the current block of actions.
@@ -86,23 +86,22 @@
* exec <application [parameter [parameter [...]]]> ;
Execute an application. Takes variable number of parameters, but the
- last parameter must be terminated with semicolon. Again, all variables
- are set as environmental.
+ last parameter must be terminated with semicolon. Again, all
+ variables are set as environmental.
- If you need to escape the ';', use '\\;'. Only applies for actions with
- variable number of parameters.
+ If you need to escape the ';', use '\\;'. Only applies for actions
+ with variable number of parameters.
* makedev <path> <mode>
- Create a device with given mode. The mode is not in octal unless it
- starts with '0', eg. "0644" != "644".
+ Create a device with given mode. Mode is interpreted as octal.
Major, minor and devpath must be set for makedev to be able to work.
Tests for these variables are also performed internally in makedev
function.
* symlink <target> <linkname>
- Create a symbolic link (symlink, also known as soft link) pointing at
- target with name linkname.
+ Create a symbolic link (symlink, also known as soft link) pointing
+ at target with name linkname.
* chown <path> <owner name>
Change owner of path to owner name.
2007-06-30 11:05:14 +00:00
@@ -111,12 +110,32 @@
2007-06-25 09:46:37 +00:00
Change group of path to group name.
* chmod <path> <mode>
- Change mode of path to given mode. Like with makedev, heading '0' is
- necessary for the mode to be interpreted as octal.
+ Change mode of path to given mode. Mode is interpreted as octal.
* setenv <key> <value>
Sets environmental variable key to the given value. If an env var
of the given name already exists, it gets overwritten.
+
+ * printdebug
+ Prints all variables read from kernel.
2007-06-30 11:05:14 +00:00
+
+ FLAGS
+ -----
+
+Flags are, syntactically, just like actions; their semantical value is different however.
+Instead of doing something, they instead change the general behavior of the processing
+of the given rule.
+
+Note that for flags to work, you also have to invoke it with --override.
+
+Currently, only one flag is implemented:
+
+ * nothrottle
+ Forcibly overrides hotplug2 throttling mechanism. If _all_ rules that match
+ the given kernel event have 'nothrottle' set, hotplug2 will not wait for
+ children count to get under max-children limit. That allows to throttle
+ eg. helper application execution or modprobes, but yet keep node devices
+ fast.
2007-06-25 09:46:37 +00:00
ESCAPING
--------
2007-06-30 11:05:14 +00:00
@@ -136,8 +155,9 @@
2007-06-25 09:46:37 +00:00
SAMPLE CONFIG
-------------
-Below is a sample hotplug2.rules file. It loads modules to all available devices
-quietly and creates device nodes for block devices.
+Below is a sample hotplug2.rules file. It loads modules to all available
+devices quietly and creates device nodes for block devices. Note that this
+sample is not very viable for real life usage.
---------------------------------------------------------------------------------
MODALIAS is set {
exec modprobe -q %MODALIAS% ;
2007-06-30 11:05:14 +00:00
@@ -146,3 +166,33 @@
2007-06-25 09:46:37 +00:00
SUBSYSTEM == block, DEVPATH is set, MAJOR is set, MINOR is set {
makedev /dev/%DEVICENAME% 0644
}
+
+
+Please find also the more complex set of rules, dedicated to handling most
+common needs.
+---------------------------------------------------------------------------------
+#For debugging
+#ACTION is set {
+# printdebug
+#}
+
+# Load modules (what old hotplug did)
+MODALIAS is set {
+ exec modprobe -q %MODALIAS% ;
+}
+
+# Create device nodes
+DEVPATH is set, MAJOR is set, MINOR is set {
+ makedev /dev/%DEVICENAME% 0644
+}
+
+# Mount a USB flashdisk
+ACTION == add, PHYSDEVPATH ~~ "/usb[0-9]*/", DEVICENAME ~~ "^sd[a-z][0-9]+$", DEVPATH is set, MAJOR is set, MINOR is set {
+ makedev /dev/%DEVICENAME% 0644
+ exec mount /dev/%DEVICENAME% /mnt/%DEVICENAME%
+}
+
+# Unmount a USB flashdisk
+ACTION == remove, PHYSDEVPATH ~~ "/usb[0-9]*/", DEVICENAME ~~ "^sd[a-z][0-9]+$", MAJOR is set, MINOR is set {
+ exec umount /mnt/%DEVICENAME%
+}
2007-06-30 11:05:14 +00:00
diff -urN -x.svn hotplug2-0.9/docs/Makefile hotplug2/docs/Makefile
2007-06-25 09:46:37 +00:00
--- hotplug2-0.9/docs/Makefile 2006-09-26 00:27:02.000000000 +0200
2007-06-30 11:05:14 +00:00
+++ hotplug2/docs/Makefile 2007-06-28 14:50:59.875955008 +0200
2007-06-25 09:46:37 +00:00
@@ -2,12 +2,13 @@
BINS=
SUBDIRS=
-
+DESTDIR=
+MANDIR=/usr/share/man
all:
install:
- $(INSTALL) $(wildcard *.8) /usr/share/man/man8/
+ $(INSTALL) $(wildcard *.8) $(DESTDIR)$(MANDIR)/man8/
include ../common.mak
2007-06-30 11:05:14 +00:00
diff -urN -x.svn hotplug2-0.9/examples/Makefile hotplug2/examples/Makefile
2007-06-25 09:46:37 +00:00
--- hotplug2-0.9/examples/Makefile 2006-09-26 01:03:08.000000000 +0200
2007-06-30 11:05:14 +00:00
+++ hotplug2/examples/Makefile 2007-06-28 14:50:59.991937376 +0200
2007-06-25 09:46:37 +00:00
@@ -2,19 +2,23 @@
BINS=
SUBDIRS=
+DESTDIR=
+KERNELVER=`uname -r`
all:
install:
- case "`uname -r`" in \
- 2.6.*) \
- $(INSTALL) hotplug2.rules-2.6kernel /etc/hotplug2.rules \
- ;; \
- *) \
- $(INSTALL) hotplug2.rules-2.4kernel /etc/hotplug2.rules \
- ;; \
- esac
+ if ! [ -e "/etc/hotplug2.rules" ]; then \
+ case "$(KERNELVER)" in \
+ 2.6.*) \
+ $(INSTALL) hotplug2.rules-2.6kernel $(DESTDIR)/etc/hotplug2.rules \
+ ;; \
+ *) \
+ $(INSTALL) hotplug2.rules-2.4kernel $(DESTDIR)/etc/hotplug2.rules \
+ ;; \
+ esac; \
+ fi;
include ../common.mak
2007-06-30 11:05:14 +00:00
diff -urN -x.svn hotplug2-0.9/hotplug2.c hotplug2/hotplug2.c
2007-06-25 09:46:37 +00:00
--- hotplug2-0.9/hotplug2.c 2006-10-08 15:18:23.000000000 +0200
2007-06-30 11:05:14 +00:00
+++ hotplug2/hotplug2.c 2007-06-30 12:59:20.459674000 +0200
@@ -36,6 +36,7 @@
pid_t coldplug_p;
int coldplug = 1;
int persistent = 0;
+int override = 0;
int max_child_c = 20;
int dumb = 0;
int terminate = 0;
@@ -324,6 +325,41 @@
free_hotplug2_event(event);
}
+
+int flags_eval(struct hotplug2_event_t *event, struct rules_t *rules) {
+ int flags = FLAG_ALL;
+ int match = 0;
+ int i, j;
+
+ for (i = 0; i < rules->rules_c; i++) {
+ match = 1;
+
+ for (j = 0; j < rules->rules[i].conditions_c; j++) {
+ if (rule_condition_eval(event, &rules->rules[i].conditions[j]) != EVAL_MATCH) {
+ match = 0;
+ break;
+ }
+ }
+
+ /*
+ * Logical AND between flags we've got already and
+ * those we're adding.
+ */
+ if (match) {
+ rule_flags(event, &rules->rules[i]);
+ flags &= rules->rules[i].flags;
+ }
+ }
+
+ /*
+ * A little trick; if no rule matched, we return FLAG_ALL
+ * and have it skipped completely.
+ */
+
+ return flags;
+}
+#else
+#define perform_action(event, rules)
#endif
void perform_dumb_action(struct hotplug2_event_t *event, char *modalias) {
@@ -390,7 +426,9 @@
int size;
2007-06-25 09:46:37 +00:00
int rv = 0;
int i;
2007-06-30 11:05:14 +00:00
+ int flags;
2007-06-25 09:46:37 +00:00
char *coldplug_command = NULL;
+ char *rules_file = HOTPLUG2_RULE_PATH;
sigset_t block_mask;
struct rules_t *rules = NULL;
2007-06-30 11:05:14 +00:00
@@ -402,6 +440,7 @@
{"persistent", &persistent},
{"coldplug", &coldplug},
{"udevtrigger", &coldplug}, /* compatibility */
+ {"override", &override},
#ifdef HAVE_RULES
{"dumb", &dumb},
#endif
@@ -435,15 +474,31 @@
2007-06-25 09:46:37 +00:00
break;
modprobe_command = *argv;
+ } else if (!strcmp(*argv, "--set-rules-file")) {
+ argv++;
+ argc--;
+ if (argc <= 0)
+ break;
+
+ rules_file = *argv;
}
}
}
}
-#ifdef HAVE_RULES
+#ifndef HAVE_RULES
+ /*
+ * We don't use rules, so we use dumb mode only.
+ */
+ dumb = 1;
+#else
+ /*
+ * We're not in dumb mode, parse the rules. If we fail,
+ * faillback to dumb mode.
+ */
if (!dumb) {
filemap = MAP_FAILED;
- rule_fd = open(HOTPLUG2_RULE_PATH, O_RDONLY | O_NOATIME);
+ rule_fd = open(rules_file, O_RDONLY | O_NOATIME);
if (rule_fd == -1) {
dumb = 1;
ERROR("rules parse","Unable to open rules file: %s.", strerror(errno));
2007-06-30 11:05:14 +00:00
@@ -477,10 +532,12 @@
2007-06-25 09:46:37 +00:00
if (dumb == 1)
ERROR("rules parse","Parsing rules failed, switching to dumb mode.");
- } else if (!modprobe_command)
-#else
- if (dumb && !modprobe_command)
+ } else
#endif
+ /*
+ * No modprobe command specified, let's autodetect it.
+ */
+ if (!modprobe_command)
{
if (get_modprobe_command()) {
ERROR("modprobe_command","Unable to autodetect modprobe command.");
2007-06-30 11:05:14 +00:00
@@ -536,7 +593,7 @@
2007-06-25 09:46:37 +00:00
modalias = get_hotplug2_value_by_key(tmpevent, "MODALIAS");
seqnum = get_hotplug2_value_by_key(tmpevent, "SEQNUM");
-
+
if (seqnum == NULL) {
free_hotplug2_event(tmpevent);
ERROR("reading events", "Malformed event read (missing SEQNUM).");
2007-06-30 11:05:14 +00:00
@@ -547,13 +604,35 @@
2007-06-25 09:46:37 +00:00
if (cur_seqnum > highest_seqnum)
highest_seqnum = cur_seqnum;
- if (tmpevent->action == ACTION_ADD && (!dumb || modalias != NULL)) {
+ if ((dumb && tmpevent->action == ACTION_ADD && modalias != NULL) || (!dumb)) {
2007-06-30 11:05:14 +00:00
+ /*
+ * Pre-evaluation
+ */
+ if (!dumb && override) {
+ flags = flags_eval(tmpevent, rules);
+
+ DBG("flags", "flag returned: %8x", flags);
+
+ if (flags == FLAG_ALL)
+ continue;
+ } else {
+ flags = FLAG_UNSET;
+ }
+
2007-06-25 09:46:37 +00:00
/*
* We have more children than we want. Wait until SIGCHLD handler reduces
* their numbers.
2007-06-30 11:05:14 +00:00
+ *
+ * Unless, of course, we've specified otherwise and no rules that match
+ * need throttling.
*/
- while (child_c >= max_child_c) {
- usleep(HOTPLUG2_THROTTLE_INTERVAL);
+ if (!flags & FLAG_NOTHROTTLE) {
+ /*
+ * Okay, throttle away!
+ */
+ while (child_c >= max_child_c) {
+ usleep(HOTPLUG2_THROTTLE_INTERVAL);
+ }
}
sigemptyset(&block_mask);
@@ -562,17 +641,15 @@
p = fork();
switch (p) {
case -1:
- ERROR("event","fork failed: %s.", strerror(errno));
+ ERROR("event", "fork failed: %s.", strerror(errno));
break;
case 0:
2007-06-25 09:46:37 +00:00
sigprocmask(SIG_UNBLOCK, &block_mask, 0);
signal(SIGCHLD, SIG_DFL);
signal(SIGUSR1, SIG_DFL);
-#ifdef HAVE_RULES
if (!dumb)
perform_action(dup_hotplug2_event(tmpevent), rules);
else
-#endif
perform_dumb_action(dup_hotplug2_event(tmpevent), modalias);
exit(0);
break;
2007-06-30 11:05:14 +00:00
@@ -593,12 +670,10 @@
2007-06-25 09:46:37 +00:00
signal(SIGINT, SIG_DFL);
signal(SIGCHLD, SIG_DFL);
-#ifdef HAVE_RULES
if (!dumb) {
rules_free(rules);
free(rules);
}
-#endif
cleanup();
2007-06-30 11:05:14 +00:00
diff -urN -x.svn hotplug2-0.9/linux24_compat/hotplug2-modwrap.c hotplug2/linux24_compat/hotplug2-modwrap.c
2007-06-25 09:46:37 +00:00
--- hotplug2-0.9/linux24_compat/hotplug2-modwrap.c 2006-09-25 22:23:07.000000000 +0200
2007-06-30 11:05:14 +00:00
+++ hotplug2/linux24_compat/hotplug2-modwrap.c 2007-06-28 14:50:59.926947256 +0200
2007-06-25 09:46:37 +00:00
@@ -122,6 +122,12 @@
free(module);
free(line);
}
+
+ if (strcmp(argv[argc - 1], match_alias) == 0) {
+ if (execute(argv)) {
+ ERROR("execute", "Unable to execute: `%s'.", argv[0]);
+ }
+ }
free(filename);
free(match_alias);
2007-06-30 11:05:14 +00:00
diff -urN -x.svn hotplug2-0.9/linux24_compat/Makefile hotplug2/linux24_compat/Makefile
2007-06-25 09:46:37 +00:00
--- hotplug2-0.9/linux24_compat/Makefile 2006-09-26 00:26:46.000000000 +0200
2007-06-30 11:05:14 +00:00
+++ hotplug2/linux24_compat/Makefile 2007-06-28 14:50:59.926947256 +0200
2007-06-25 09:46:37 +00:00
@@ -2,13 +2,14 @@
BINS=generate_alias hotplug2-coldplug-2.4 hotplug2-modwrap
SUBDIRS=
+DESTDIR=
all: $(BINS)
install:
- $(INSTALL_BIN) hotplug2-coldplug-2.4 hotplug2-modwrap /sbin/
- $(INSTALL_BIN) generate_alias /usr/sbin/
+ $(INSTALL_BIN) hotplug2-coldplug-2.4 hotplug2-modwrap $(DESTDIR)/sbin/
+ $(INSTALL_BIN) generate_alias $(DESTDIR)/usr/sbin/
hotplug2-coldplug-2.4: hotplug2-coldplug-2.4.o ../parser_utils.o ../filemap_utils.o ../mem_utils.o
2007-06-30 11:05:14 +00:00
diff -urN -x.svn hotplug2-0.9/Makefile hotplug2/Makefile
2007-06-25 09:46:37 +00:00
--- hotplug2-0.9/Makefile 2006-09-26 01:03:08.000000000 +0200
2007-06-30 11:05:14 +00:00
+++ hotplug2/Makefile 2007-06-28 14:51:00.014933880 +0200
2007-06-25 09:46:37 +00:00
@@ -2,12 +2,13 @@
BINS=hotplug2 hotplug2-dnode
SUBDIRS=linux24_compat docs examples
+DESTDIR=
all: $(BINS)
install:
- $(INSTALL_BIN) $(BINS) /sbin/
+ $(INSTALL_BIN) $(BINS) $(DESTDIR)/sbin/
hotplug2: hotplug2.o childlist.o mem_utils.o rules.o
2007-06-30 11:05:14 +00:00
diff -urN -x.svn hotplug2-0.9/rules.c hotplug2/rules.c
2007-06-25 09:46:37 +00:00
--- hotplug2-0.9/rules.c 2006-09-29 22:19:31.000000000 +0200
2007-06-30 11:05:14 +00:00
+++ hotplug2/rules.c 2007-06-30 12:44:52.501430000 +0200
2007-06-25 09:46:37 +00:00
@@ -59,6 +59,24 @@
free(path);
}
+static void rmdir_p(char *path) {
+ char *ptr;
+
+ path = strdup(path);
+ ptr = path;
+ while (ptr != NULL) {
+ ptr = strrchr(path, '/');
+ if (ptr == NULL)
+ break;
+
+ *ptr = '\0';
+
+ if (rmdir(path))
+ break;
+ }
+ free(path);
+}
+
static char *replace_str(char *hay, char *needle, char *replacement) {
char *ptr, *start, *bptr, *buf;
int occurences, j;
2007-06-30 11:05:14 +00:00
@@ -128,7 +146,7 @@
return buf;
}
-inline int isescaped(char *hay, char *ptr) {
+static inline int isescaped(char *hay, char *ptr) {
if (ptr <= hay)
return 0;
2007-06-25 09:46:37 +00:00
@@ -250,11 +268,30 @@
return rv;
}
-static int chown_chgrp(int action, char *file, char *param) {
+static int chmod_file(struct hotplug2_event_t *event, char *file, char *value) {
+ int rv;
+
+ file = replace_key_by_value(strdup(file), event);
+ value = replace_key_by_value(strdup(value), event);
+
+ rv = chmod(file, strtoul(value, 0, 8));
+
+ free(file);
+ free(value);
+
+ return rv;
+}
+
+static int chown_chgrp(struct hotplug2_event_t *event, int action, char *file, char *param) {
struct group *grp;
struct passwd *pwd;
int rv;
-
+
+ file = replace_key_by_value(strdup(file), event);
+ param = replace_key_by_value(strdup(param), event);
+
+ rv = -1;
+
switch (action) {
case ACT_CHOWN:
pwd = getpwnam(param);
2007-06-30 11:05:14 +00:00
@@ -265,11 +302,23 @@
2007-06-25 09:46:37 +00:00
rv = chown(file, -1, grp->gr_gid);
break;
}
+
+ free(file);
+ free(param);
- return -1;
+ return rv;
+}
+
+static int print_debug(struct hotplug2_event_t *event) {
+ int i;
+
+ for (i = 0; i < event->env_vars_c; i++)
+ printf("%s=%s\n", event->env_vars[i].key, event->env_vars[i].value);
+
+ return 0;
}
2007-06-30 11:05:14 +00:00
-static int rule_condition_eval(struct hotplug2_event_t *event, struct condition_t *condition) {
+int rule_condition_eval(struct hotplug2_event_t *event, struct condition_t *condition) {
int rv;
char *event_value = NULL;
regex_t preg;
2007-06-25 09:46:37 +00:00
@@ -347,11 +396,11 @@
last_rv = make_dev_from_event(event, rule->actions[i].parameter[0], strtoul(rule->actions[i].parameter[1], NULL, 0));
break;
case ACT_CHMOD:
- last_rv = chmod(rule->actions[i].parameter[0], strtoul(rule->actions[i].parameter[1], NULL, 0));
+ last_rv = chmod_file(event, rule->actions[i].parameter[0], rule->actions[i].parameter[1]);
break;
case ACT_CHOWN:
case ACT_CHGRP:
- last_rv = chown_chgrp(rule->actions[i].type, rule->actions[i].parameter[0], rule->actions[i].parameter[1]);
+ last_rv = chown_chgrp(event, rule->actions[i].type, rule->actions[i].parameter[0], rule->actions[i].parameter[1]);
break;
case ACT_SYMLINK:
last_rv = make_symlink(event, rule->actions[i].parameter[0], rule->actions[i].parameter[1]);
2007-06-30 11:05:14 +00:00
@@ -365,6 +414,27 @@
2007-06-25 09:46:37 +00:00
case ACT_SETENV:
last_rv = setenv(rule->actions[i].parameter[0], rule->actions[i].parameter[1], 1);
break;
+ case ACT_REMOVE:
+ last_rv = unlink(rule->actions[i].parameter[0]);
+ rmdir_p(rule->actions[i].parameter[0]);
+ break;
+ case ACT_DEBUG:
+ last_rv = print_debug(event);
2007-06-30 11:05:14 +00:00
+ break;
+ }
+ }
+
+ return 0;
+}
+
+int rule_flags(struct hotplug2_event_t *event, struct rule_t *rule) {
+ int i;
+
+ for (i = 0; i < rule->actions_c; i++) {
+ switch (rule->actions[i].type) {
+ case ACT_FLAG_NOTHROTTLE:
+ rule->flags |= FLAG_NOTHROTTLE;
2007-06-25 09:46:37 +00:00
+ break;
}
}
2007-06-30 11:05:14 +00:00
@@ -518,6 +588,9 @@
2007-06-25 09:46:37 +00:00
{"chmod", 2, ACT_CHMOD},
{"chgrp", 2, ACT_CHGRP},
{"setenv", 2, ACT_SETENV},
+ {"remove", 1, ACT_REMOVE},
2007-06-30 11:05:14 +00:00
+ {"nothrottle", 0, ACT_FLAG_NOTHROTTLE},
2007-06-25 09:46:37 +00:00
+ {"printdebug", 0, ACT_DEBUG},
/*symlink*/
{"symlink", 2, ACT_SYMLINK},
{"softlink", 2, ACT_SYMLINK},
2007-06-30 11:05:14 +00:00
diff -urN -x.svn hotplug2-0.9/rules.h hotplug2/rules.h
2007-06-25 09:46:37 +00:00
--- hotplug2-0.9/rules.h 2006-09-25 13:42:22.000000000 +0200
2007-06-30 11:05:14 +00:00
+++ hotplug2/rules.h 2007-06-30 12:44:52.501430000 +0200
@@ -24,9 +24,12 @@
2007-06-25 09:46:37 +00:00
#define ACT_CHGRP 6 /* chgrp <...> */
#define ACT_CHOWN 7 /* chown <...> */
#define ACT_SYMLINK 8 /* symlink <...> */
-#define ACT_NEXT_EVENT 9 /* next */
+#define ACT_NEXT_EVENT 9 /* next */
#define ACT_NEXT_IF_FAILED 10 /* next_if_failed */
#define ACT_SETENV 11 /* setenv <...> */
+#define ACT_REMOVE 12 /* remove <...> */
+#define ACT_DEBUG 13 /* debug */
2007-06-30 11:05:14 +00:00
+#define ACT_FLAG_NOTHROTTLE 14 /* sets 'nothrottle' flag */
2007-06-25 09:46:37 +00:00
#define EVAL_MATCH 1
#define EVAL_NOT_MATCH 0
2007-06-30 11:05:14 +00:00
@@ -42,6 +45,11 @@
#define STATUS_INITIATOR 3 /* ',' for next cond, '{' for block*/
#define STATUS_ACTION 4 /* viz ACT_* and '}' for end of block */
+#define FLAG_UNSET 0
+#define FLAG_ALL 0xffffffff
+#define FLAG_NOTHROTTLE 1 /* We want this rule to ignore max_children limit */
+
+
struct key_rec_t {
char *key;
int param;
@@ -65,6 +73,8 @@
struct action_t *actions;
int actions_c;
+
+ int flags;
};
struct rules_t {
@@ -72,7 +82,9 @@
int rules_c;
};
+int rule_condition_eval(struct hotplug2_event_t *, struct condition_t *);
int rule_execute(struct hotplug2_event_t *, struct rule_t *);
+int rule_flags(struct hotplug2_event_t *, struct rule_t *);
void rules_free(struct rules_t *);
struct rules_t *rules_from_config(char *);
diff -urN -x.svn hotplug2-0.9/TODO hotplug2/TODO
2007-06-25 09:46:37 +00:00
--- hotplug2-0.9/TODO 1970-01-01 01:00:00.000000000 +0100
2007-06-30 11:05:14 +00:00
+++ hotplug2/TODO 2007-06-28 14:51:00.012934184 +0200
2007-06-25 09:46:37 +00:00
@@ -0,0 +1 @@
+ - live rules update (via inotify)
