2020-04-19 08:04:06 +00:00
|
|
|
From 4e4637b10374ede3cd33d7e1b389e6cea6343ea3 Mon Sep 17 00:00:00 2001
|
|
|
|
|
From: Colin Ian King <colin.king@canonical.com>
|
|
|
|
|
Date: Tue, 12 Nov 2019 13:05:23 +0000
|
|
|
|
|
Subject: [PATCH] net: dsa: mv88e6xxx: fix broken if statement because of a
|
|
|
|
|
stray semicolon
|
|
|
|
|
|
|
|
|
|
There is a stray semicolon in an if statement that will cause a dev_err
|
|
|
|
|
message to be printed unconditionally. Fix this by removing the stray
|
|
|
|
|
semicolon.
|
|
|
|
|
|
|
|
|
|
Addresses-Coverity: ("Stay semicolon")
|
|
|
|
|
Fixes: f0942e00a1ab ("net: dsa: mv88e6xxx: Add support for port mirroring")
|
|
|
|
|
Signed-off-by: Colin Ian King <colin.king@canonical.com>
|
|
|
|
|
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
|
|
|
|
|
Signed-off-by: David S. Miller <davem@davemloft.net>
|
|
|
|
|
---
|
|
|
|
|
drivers/net/dsa/mv88e6xxx/chip.c | 2 +-
|
|
|
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
|
|
|
|
|
|
--- a/drivers/net/dsa/mv88e6xxx/chip.c
|
|
|
|
|
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
|
2020-12-02 11:45:04 +00:00
|
|
|
@@ -4989,7 +4989,7 @@ static void mv88e6xxx_port_mirror_del(st
|
2020-04-19 08:04:06 +00:00
|
|
|
if (chip->info->ops->set_egress_port(chip,
|
|
|
|
|
direction,
|
|
|
|
|
dsa_upstream_port(ds,
|
|
|
|
|
- port)));
|
|
|
|
|
+ port)))
|
|
|
|
|
dev_err(ds->dev, "failed to set egress port\n");
|
|
|
|
|
}
|
|
|
|
|
|
